Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: [MI non-stop 09/11] Don't care about user-defined thread if --thread is present.
Date: Fri, 11 Jul 2008 13:52:00 -0000	[thread overview]
Message-ID: <200807111451.59696.pedro@codesourcery.com> (raw)
In-Reply-To: <200806282058.04805.vladimir@codesourcery.com>

A Saturday 28 June 2008 17:58:04, Vladimir Prus wrote:
> If an MI command has --thread parameter, we don't care in any way
> that user selected thread is. Will commit after core non-stop is in.
>

Note that the version that was committed doesn't have user_selected_ptid
anymore, and neither an inferior_ptid == null_ptid case, as long as the
target still has execution.  I think that you're already checking
if the thread is THREAD_EXITED somewhere else before letting the
command run, so this will disappear.

> - Volodya
>
> 	* mi/mi-main.c (mi_cmd_execute): Suppress check for
> 	non-null user-selected thread if explicit thread is specified.
> ---
>  gdb/mi/mi-main.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
> index 0b5d076..7d4adc4 100644
> --- a/gdb/mi/mi-main.c
> +++ b/gdb/mi/mi-main.c
> @@ -1184,7 +1184,8 @@ mi_cmd_execute (struct mi_parse *parse)
>
>    if (parse->cmd->argv_func != NULL)
>      {
> -      if (target_can_async_p ()
> +      if (parse->thread == -1
> +	  && target_can_async_p ()
>  	  && target_has_execution
>   	  && (ptid_equal (user_selected_ptid, null_ptid))
>  	  && (strcmp (parse->command, "thread-info") != 0



-- 
Pedro Alves


  reply	other threads:[~2008-07-11 13:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-28 17:02 Vladimir Prus
2008-07-11 13:52 ` Pedro Alves [this message]
2008-07-13  4:34   ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807111451.59696.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox