From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6681 invoked by alias); 11 Jul 2008 13:52:20 -0000 Received: (qmail 6673 invoked by uid 22791); 11 Jul 2008 13:52:19 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 Jul 2008 13:52:01 +0000 Received: (qmail 7579 invoked from network); 11 Jul 2008 13:52:00 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 Jul 2008 13:52:00 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [MI non-stop 09/11] Don't care about user-defined thread if --thread is present. Date: Fri, 11 Jul 2008 13:52:00 -0000 User-Agent: KMail/1.9.9 Cc: Vladimir Prus References: <200806282058.04805.vladimir@codesourcery.com> In-Reply-To: <200806282058.04805.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807111451.59696.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00201.txt.bz2 A Saturday 28 June 2008 17:58:04, Vladimir Prus wrote: > If an MI command has --thread parameter, we don't care in any way > that user selected thread is. Will commit after core non-stop is in. > Note that the version that was committed doesn't have user_selected_ptid anymore, and neither an inferior_ptid == null_ptid case, as long as the target still has execution. I think that you're already checking if the thread is THREAD_EXITED somewhere else before letting the command run, so this will disappear. > - Volodya > > * mi/mi-main.c (mi_cmd_execute): Suppress check for > non-null user-selected thread if explicit thread is specified. > --- > gdb/mi/mi-main.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c > index 0b5d076..7d4adc4 100644 > --- a/gdb/mi/mi-main.c > +++ b/gdb/mi/mi-main.c > @@ -1184,7 +1184,8 @@ mi_cmd_execute (struct mi_parse *parse) > > if (parse->cmd->argv_func != NULL) > { > - if (target_can_async_p () > + if (parse->thread == -1 > + && target_can_async_p () > && target_has_execution > && (ptid_equal (user_selected_ptid, null_ptid)) > && (strcmp (parse->command, "thread-info") != 0 -- Pedro Alves