Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: gdb-patches@sourceware.org
Cc: MR.Swami.Reddy@nsc.com
Subject: Committed: fix sim/cr16/interp.c hash prototype
Date: Fri, 11 Jul 2008 01:35:00 -0000	[thread overview]
Message-ID: <200807110135.m6B1ZRxp032164@ignucius.se.axis.com> (raw)

While cleaning up the recently introduced -lz mess in sim, I
found that the cr16 sim didn't compile for me (gcc-4.0.2-8.fc4):

gcc -c -DHAVE_CONFIG_H     -DPROFILE=1 -DWITH_PROFILE=-1          -DDEFAULT_INLINE=0       -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized    -DNEED_UI_LOOP_HOOK -DSIM_HAVE_ENVIRONMENT   -I. -I/home/hp/combined/sim_write/src/sim/cr16 -I../common -I/home/hp/combined/sim_write/src/sim/cr16/../common -I../../include -I/home/hp/combined/sim_write/src/sim/cr16/../../include -I../../bfd -I/home/hp/combined/sim_write/src/sim/cr16/../../bfd -I../../opcodes -I/home/hp/combined/sim_write/src/sim/cr16/../../opcodes  -g -O2 /home/hp/combined/sim_write/src/sim/cr16/interp.c
x/src/sim/cr16/interp.c:96: error: conflicting types for `hash'
x/src/sim/cr16/interp.c:53: error: previous declaration of `hash' here
x/src/sim/cr16/interp.c: In function `do_run':
x/src/sim/cr16/interp.c:400: warning: comparison between pointer and integer
make[3]: *** [interp.o] Error 1

As the prototype isn't required, I fixed it thus, committed:

sim/cr16:
	* interp.c (hash): Remove incorrect prototype.

Index: interp.c
===================================================================
RCS file: /cvs/src/src/sim/cr16/interp.c,v
retrieving revision 1.2
diff -p -u -r1.2 interp.c
--- interp.c	5 May 2008 09:19:42 -0000	1.2
+++ interp.c	11 Jul 2008 01:29:02 -0000
@@ -50,7 +50,6 @@ asection *text;
 bfd_vma text_start;
 bfd_vma text_end;
 
-static long hash PARAMS ((uint64 linsn, int));
 static struct hash_entry *lookup_hash PARAMS ((uint64 ins, int size));
 static void get_operands PARAMS ((operand_desc *s, uint64 mcode, int isize, int nops));
 static int do_run PARAMS ((uint64 mc));

brgds, H-P


             reply	other threads:[~2008-07-11  1:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-11  1:35 Hans-Peter Nilsson [this message]
2008-07-11  8:52 ` M R Swami Reddy
2008-07-11 10:49   ` Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807110135.m6B1ZRxp032164@ignucius.se.axis.com \
    --to=hans-peter.nilsson@axis.com \
    --cc=MR.Swami.Reddy@nsc.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox