From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18829 invoked by alias); 11 Jul 2008 01:35:52 -0000 Received: (qmail 18816 invoked by uid 22791); 11 Jul 2008 01:35:52 -0000 X-Spam-Check-By: sourceware.org Received: from miranda.se.axis.com (HELO miranda.se.axis.com) (193.13.178.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 Jul 2008 01:35:34 +0000 Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.84.50.18]) by miranda.se.axis.com (8.13.4/8.13.4/Debian-3sarge3) with ESMTP id m6B1ZSfZ023254; Fri, 11 Jul 2008 03:35:28 +0200 Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id m6B1ZSEv032168; Fri, 11 Jul 2008 03:35:28 +0200 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id m6B1ZRxp032164; Fri, 11 Jul 2008 03:35:27 +0200 Date: Fri, 11 Jul 2008 01:35:00 -0000 Message-Id: <200807110135.m6B1ZRxp032164@ignucius.se.axis.com> From: Hans-Peter Nilsson To: gdb-patches@sourceware.org CC: MR.Swami.Reddy@nsc.com Subject: Committed: fix sim/cr16/interp.c hash prototype MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00177.txt.bz2 While cleaning up the recently introduced -lz mess in sim, I found that the cr16 sim didn't compile for me (gcc-4.0.2-8.fc4): gcc -c -DHAVE_CONFIG_H -DPROFILE=1 -DWITH_PROFILE=-1 -DDEFAULT_INLINE=0 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized -DNEED_UI_LOOP_HOOK -DSIM_HAVE_ENVIRONMENT -I. -I/home/hp/combined/sim_write/src/sim/cr16 -I../common -I/home/hp/combined/sim_write/src/sim/cr16/../common -I../../include -I/home/hp/combined/sim_write/src/sim/cr16/../../include -I../../bfd -I/home/hp/combined/sim_write/src/sim/cr16/../../bfd -I../../opcodes -I/home/hp/combined/sim_write/src/sim/cr16/../../opcodes -g -O2 /home/hp/combined/sim_write/src/sim/cr16/interp.c x/src/sim/cr16/interp.c:96: error: conflicting types for `hash' x/src/sim/cr16/interp.c:53: error: previous declaration of `hash' here x/src/sim/cr16/interp.c: In function `do_run': x/src/sim/cr16/interp.c:400: warning: comparison between pointer and integer make[3]: *** [interp.o] Error 1 As the prototype isn't required, I fixed it thus, committed: sim/cr16: * interp.c (hash): Remove incorrect prototype. Index: interp.c =================================================================== RCS file: /cvs/src/src/sim/cr16/interp.c,v retrieving revision 1.2 diff -p -u -r1.2 interp.c --- interp.c 5 May 2008 09:19:42 -0000 1.2 +++ interp.c 11 Jul 2008 01:29:02 -0000 @@ -50,7 +50,6 @@ asection *text; bfd_vma text_start; bfd_vma text_end; -static long hash PARAMS ((uint64 linsn, int)); static struct hash_entry *lookup_hash PARAMS ((uint64 ins, int size)); static void get_operands PARAMS ((operand_desc *s, uint64 mcode, int isize, int nops)); static int do_run PARAMS ((uint64 mc)); brgds, H-P