Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Don't try to report 	resumed thread it the thread list is empty.
Date: Wed, 09 Jul 2008 12:04:00 -0000	[thread overview]
Message-ID: <200807091604.11646.vladimir@codesourcery.com> (raw)
In-Reply-To: <200807091131.22424.pedro@codesourcery.com>

On Wednesday 09 July 2008 14:31:21 Pedro Alves wrote:
> A Saturday 05 July 2008 18:58:29, Vladimir Prus wrote:
> > I've checked in the below to make GDB not assert in MI mode on
> > targets where single-threaded programs have zero threads in the
> > GDB thread table.
> >
> 
> FYI, running the MI testsuite on a target that doesn't register
> the main thread in ST programs, 

For the record, which target did you test on?

> has failures that look like: 
> 
> -exec-continue
> ^running
> *running
> (gdb) 
> *stopped,reason="breakpoint-hit",disp="keep",bkptno="2",thread-id="0",frame={addr="0x000087e0",func="do_special_tests",args=[],file="../../../src/gdb/testsuite/gdb.mi/var-cmd.c",fullname="/home/pedro/gdb/monitor_always_a_thread/src/gdb/testsuite/gdb.mi/var-cmd.c",line="319"}
> (gdb) 
> FAIL: gdb.mi/mi2-var-display.exp: continue to do_special_tests (failed to 
> resume)
> 
> I believe the issue is that in lib/mi-support.exp, *running matching assumes
> there is -thread-id field
>  
> -re "220\\^running\[\r\n\]+\\*running,thread-id=\"\[^\"\]+\"\r\n$mi_gdb_prompt$" 
> {}
> 
> I notice that there are other places that are outputing -thread-id="0", e.g.:
> 
> *stopped,reason="breakpoint-hit",disp="keep",bkptno="2",thread-id="0",frame={addr="0x000087e0",func="do_special_tests",args=[],file="../../../src/gdb/testsuite/gdb.mi/var-cmd.c",fullname="/home/pedro/gdb/monitor_always_a_thread/src/gdb/testsuite/gdb.mi/var-cmd.c",line="319"} 
> (gdb) 
> 
> So maybe we should make this consistent, and output -thread-id="0"
> in *running as well?

I'm not sure which way we want to make it consistent. Outputiing "thread-id" 
with a "I don't exist" value of thread id seems a little bit distasteful.
I guess I can modify regexp to make thread-id optional.

- Volodya


  reply	other threads:[~2008-07-09 12:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-05 17:58 Vladimir Prus
2008-07-09 10:31 ` Pedro Alves
2008-07-09 12:04   ` Vladimir Prus [this message]
2008-07-09 12:52     ` Pedro Alves
2008-07-09 13:04       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807091604.11646.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox