From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6721 invoked by alias); 9 Jul 2008 12:04:46 -0000 Received: (qmail 6711 invoked by uid 22791); 9 Jul 2008 12:04:46 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 09 Jul 2008 12:04:28 +0000 Received: (qmail 2184 invoked from network); 9 Jul 2008 12:04:26 -0000 Received: from unknown (HELO 172.16.unknown.plus.ru) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Jul 2008 12:04:26 -0000 From: Vladimir Prus To: Pedro Alves Subject: Re: Don't try to report =?utf-8?q?=09resumed_thread_it_the_thread_list_is?= empty. Date: Wed, 09 Jul 2008 12:04:00 -0000 User-Agent: KMail/1.9.9 Cc: gdb-patches@sourceware.org References: <200807052158.30295.vladimir@codesourcery.com> <200807091131.22424.pedro@codesourcery.com> In-Reply-To: <200807091131.22424.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807091604.11646.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00132.txt.bz2 On Wednesday 09 July 2008 14:31:21 Pedro Alves wrote: > A Saturday 05 July 2008 18:58:29, Vladimir Prus wrote: > > I've checked in the below to make GDB not assert in MI mode on > > targets where single-threaded programs have zero threads in the > > GDB thread table. > > > > FYI, running the MI testsuite on a target that doesn't register > the main thread in ST programs, For the record, which target did you test on? > has failures that look like: > > -exec-continue > ^running > *running > (gdb) > *stopped,reason="breakpoint-hit",disp="keep",bkptno="2",thread-id="0",frame={addr="0x000087e0",func="do_special_tests",args=[],file="../../../src/gdb/testsuite/gdb.mi/var-cmd.c",fullname="/home/pedro/gdb/monitor_always_a_thread/src/gdb/testsuite/gdb.mi/var-cmd.c",line="319"} > (gdb) > FAIL: gdb.mi/mi2-var-display.exp: continue to do_special_tests (failed to > resume) > > I believe the issue is that in lib/mi-support.exp, *running matching assumes > there is -thread-id field > > -re "220\\^running\[\r\n\]+\\*running,thread-id=\"\[^\"\]+\"\r\n$mi_gdb_prompt$" > {} > > I notice that there are other places that are outputing -thread-id="0", e.g.: > > *stopped,reason="breakpoint-hit",disp="keep",bkptno="2",thread-id="0",frame={addr="0x000087e0",func="do_special_tests",args=[],file="../../../src/gdb/testsuite/gdb.mi/var-cmd.c",fullname="/home/pedro/gdb/monitor_always_a_thread/src/gdb/testsuite/gdb.mi/var-cmd.c",line="319"} > (gdb) > > So maybe we should make this consistent, and output -thread-id="0" > in *running as well? I'm not sure which way we want to make it consistent. Outputiing "thread-id" with a "I don't exist" value of thread id seems a little bit distasteful. I guess I can modify regexp to make thread-id optional. - Volodya