Implement -target-attach.

Implement -target-attach.

[Vladimir Prus]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]


This one is fairly obvious. Checked in.

- Volodya

[-- Attachment #2: commit.diff --]
[-- Type: text/x-diff, Size: 1282 bytes --]

Index: gdb/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.9514
diff -u -p -r1.9514 ChangeLog
--- gdb/ChangeLog	3 Jul 2008 23:14:35 -0000	1.9514
+++ gdb/ChangeLog	4 Jul 2008 09:03:48 -0000
@@ -1,3 +1,8 @@
+2008-07-04  Vladimir Prus  <vladimir@codesourcery.com>
+
+	Implement -target-attach.
+        * mi/mi-cmds.c (mi_cmds): Forward -target-attach to CLI attach.
+
 2008-06-21  Hui Zhu  <teawater@gmail.com>
 
 	* target-descriptions.c (maint_print_c_tdesc_cmd): Fix a memory leak.
Index: gdb/mi/mi-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-cmds.c,v
retrieving revision 1.33
diff -u -p -r1.33 mi-cmds.c
--- gdb/mi/mi-cmds.c	29 Jun 2008 17:36:36 -0000	1.33
+++ gdb/mi/mi-cmds.c	4 Jul 2008 09:03:48 -0000
@@ -117,7 +117,7 @@ struct mi_cmd mi_cmds[] =
   { "symbol-list-variables", { NULL, 0 },  NULL },
   { "symbol-locate", { NULL, 0 }, NULL },
   { "symbol-type", { NULL, 0 }, NULL },
-  { "target-attach", { NULL, 0 }, NULL },
+  { "target-attach", { "attach", 1 }, NULL },
   { "target-compare-sections", { NULL, 0 }, NULL },
   { "target-detach", { "detach", 0 }, 0 },
   { "target-disconnect", { "disconnect", 0 }, 0 },

Re: Implement -target-attach.

[Daniel Jacobowitz]

On Fri, Jul 04, 2008 at 01:13:18PM +0400, Vladimir Prus wrote:
> 
> This one is fairly obvious. Checked in.

Example
.......

N.A.

Could you update the manual, please?

-- 
Daniel Jacobowitz
CodeSourcery

Re: Implement -target-attach.

[Vladimir Prus]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

On Saturday 05 July 2008 02:46:59 Daniel Jacobowitz wrote:
> On Fri, Jul 04, 2008 at 01:13:18PM +0400, Vladimir Prus wrote:
> > 
> > This one is fairly obvious. Checked in.
> 
> Example
> .......
> 
> N.A.
> 
> Could you update the manual, please?

Does the following look OK?

- Volodya


[-- Attachment #2: target_attach_doc.diff --]
[-- Type: text/x-diff, Size: 606 bytes --]

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index df1f1a2..d2a8867 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -21628,8 +21628,14 @@ Attach to a process @var{pid} or a file @var{file} outside of @value{GDBN}.
 The corresponding @value{GDBN} command is @samp{attach}.
 
 @subsubheading Example
-N.A.
-
+@smallexample
+(gdb)
+-target-attach 34
+=thread-created,id="1"
+*stopped,thread-id="1",frame=@{addr="0xb7f7e410",func="__kernel_vsyscall",args=[]@}
+^done
+(gdb)
+@end smallexample
 
 @subheading The @code{-target-compare-sections} Command
 @findex -target-compare-sections

Re: Implement -target-attach.

[Eli Zaretskii]

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 5 Jul 2008 21:20:07 +0400
> 
> > Could you update the manual, please?
> 
> Does the following look OK?

Yes, but please keep lines inside @smallexample shorter than 70
characters.  If you need a longer line, divide it into several lines
(and tell in the accompanying text that it's supposed to be one long
line, if that's not obvious).

Re: Implement -target-attach.

[Vladimir Prus]

On Sunday 06 July 2008 10:27:59 Eli Zaretskii wrote:
> > From: Vladimir Prus <vladimir@codesourcery.com>
> > Date: Sat, 5 Jul 2008 21:20:07 +0400
> > 
> > > Could you update the manual, please?
> > 
> > Does the following look OK?
> 
> Yes, but please keep lines inside @smallexample shorter than 70
> characters.  If you need a longer line, divide it into several lines
> (and tell in the accompanying text that it's supposed to be one long
> line, if that's not obvious).

OK, I've changed the function name in example to 'bar', since it's just
example, which brought the line well under 70 characters, and checked in.

Thanks,
Volodya

Re: Implement -target-attach.

[Andreas Schwab]

Vladimir Prus <vladimir@codesourcery.com> writes:

> OK, I've changed the function name in example to 'bar', since it's just
> example, which brought the line well under 70 characters, and checked in.

You should have tested it first.  Checked in as obvious.

Andreas.

2008-07-07  Andreas Schwab  <schwab@suse.de>

	* gdb.texinfo (GDB/MI Target Manipulation): Fix last change.

--- gdb.texinfo.~1.505.~	2008-07-07 09:36:57.000000000 +0200
+++ gdb.texinfo	2008-07-07 13:52:02.000000000 +0200
@@ -21632,7 +21632,7 @@ The corresponding @value{GDBN} command i
 (gdb)
 -target-attach 34
 =thread-created,id="1"
-*stopped,thread-id="1",frame={addr="0xb7f7e410",func="bar",args=[]}
+*stopped,thread-id="1",frame=@{addr="0xb7f7e410",func="bar",args=[]@}
 ^done
 (gdb)
 @end smallexample

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."