Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org, bug-gnulib@gnu.org
Subject: Re: [RFC] Use gnulib's stdint.h.
Date: Fri, 27 Jun 2008 19:57:00 -0000	[thread overview]
Message-ID: <20080627193139.GD3946@adacore.com> (raw)
In-Reply-To: <20080627191314.GA19538@caradoc.them.org>

> Boo.  And if we change libdecnumber to use gnulib's version we'll
> undoubtedly break gcc.  If we provide gstdint.h in the gdb directory
> which redirects to <stdint.h>, will libdecnumber pick it up at this
> point?

That's pretty ingenious. Indeed, that works, since the include order
when compiling GDB files is the gdb directory, ahead of all other
dependencies. I'll send a patch shortly after having tested it.

> >     #if ! defined __cplusplus || defined __STDC_CONSTANT_MACROS
> >     
> >     /* Get WCHAR_MIN, WCHAR_MAX.  */
> >     # if ! (defined WCHAR_MIN && defined WCHAR_MAX)
> >     #  include <wchar.h>
> >     # endif
> >     
> >     #endif
> > 
> > Perhaps we could somehow generate the macro definitions ourselves,
> > which would help avoiding the include. Ideally, gnulib would take
> > care of that and avoid the include, or we could compute the WCHAR_MIN
> > and WCHAR_MAX during the GDB configury and define the macros just
> > before including gnulib/stdint.h.
> 
> I agree that having gnulib pull in wchar.h is very unfortunate.  The
> gnulib folks, CC'd, are very responsive - maybe someone on bug-gnulib
> has an idea on how to fix this?

That would be nice :-). I wanted to have a look, but m4/stdint.m4
needs a little bit of study time before I can understand it all...

-- 
Joel


  reply	other threads:[~2008-06-27 19:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05 18:41 Daniel Jacobowitz
2008-06-26 15:58 ` Daniel Jacobowitz
2008-06-27 19:31   ` Joel Brobecker
2008-06-27 19:37     ` Daniel Jacobowitz
2008-06-27 19:57       ` Joel Brobecker [this message]
2008-07-04 17:59         ` Joel Brobecker
2008-06-28  7:10       ` Bruno Haible
2008-07-01  0:28         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080627193139.GD3946@adacore.com \
    --to=brobecker@adacore.com \
    --cc=bug-gnulib@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox