From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24094 invoked by alias); 27 Jun 2008 19:31:58 -0000 Received: (qmail 24086 invoked by uid 22791); 27 Jun 2008 19:31:58 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 27 Jun 2008 19:31:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 703D42A96A0; Fri, 27 Jun 2008 15:31:39 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NHafJS6ecS3a; Fri, 27 Jun 2008 15:31:39 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 576F22A969D; Fri, 27 Jun 2008 15:31:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2552DE7ACD; Fri, 27 Jun 2008 15:31:39 -0400 (EDT) Date: Fri, 27 Jun 2008 19:57:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org, bug-gnulib@gnu.org Subject: Re: [RFC] Use gnulib's stdint.h. Message-ID: <20080627193139.GD3946@adacore.com> References: <20080605184041.GA25085@caradoc.them.org> <20080626155155.GA27012@caradoc.them.org> <20080627185907.GA11664@adacore.com> <20080627191314.GA19538@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080627191314.GA19538@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00517.txt.bz2 > Boo. And if we change libdecnumber to use gnulib's version we'll > undoubtedly break gcc. If we provide gstdint.h in the gdb directory > which redirects to , will libdecnumber pick it up at this > point? That's pretty ingenious. Indeed, that works, since the include order when compiling GDB files is the gdb directory, ahead of all other dependencies. I'll send a patch shortly after having tested it. > > #if ! defined __cplusplus || defined __STDC_CONSTANT_MACROS > > > > /* Get WCHAR_MIN, WCHAR_MAX. */ > > # if ! (defined WCHAR_MIN && defined WCHAR_MAX) > > # include > > # endif > > > > #endif > > > > Perhaps we could somehow generate the macro definitions ourselves, > > which would help avoiding the include. Ideally, gnulib would take > > care of that and avoid the include, or we could compute the WCHAR_MIN > > and WCHAR_MAX during the GDB configury and define the macros just > > before including gnulib/stdint.h. > > I agree that having gnulib pull in wchar.h is very unfortunate. The > gnulib folks, CC'd, are very responsive - maybe someone on bug-gnulib > has an idea on how to fix this? That would be nice :-). I wanted to have a look, but m4/stdint.m4 needs a little bit of study time before I can understand it all... -- Joel