From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Add comments to linux-nat.c
Date: Thu, 26 Jun 2008 14:12:00 -0000 [thread overview]
Message-ID: <20080626135149.GF22726@caradoc.them.org> (raw)
In-Reply-To: <200806141829.05646.vladimir@codesourcery.com>
On Sat, Jun 14, 2008 at 06:29:05PM +0400, Vladimir Prus wrote:
>
> With the introduction of async mode, linux-nat.c became even more complex that it
> was, and it became apparent that some high-level comments are needed. So, I've grabbed
> Pedro and Dan on IRC and extracted the knowledge from their heads into a text file.
> Here's the result. OK?
When you get a chance, could you repost this with Eli's comments
addressed? Here's a few more but the content looks fine.
> +/* This comments documents high-level logic of this file.
This comment documents the, or These comments document the.
> +blocked, the signal becomes pending and sigsuspend, presumably, immediately
> +noticed it and returns.
s/presumably, //. You're correct. Also noticed -> notices.
> +The main design point is that every time GDB is outside linux-nat.c, we have a
> +SIGCLD handler installed that is called when something happens to the target
SIGCHLD
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-06-26 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 18:19 Vladimir Prus
2008-06-14 19:51 ` Eli Zaretskii
2008-06-26 14:12 ` Daniel Jacobowitz [this message]
2008-06-26 15:56 ` Vladimir Prus
2008-06-26 16:03 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080626135149.GF22726@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox