From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28300 invoked by alias); 26 Jun 2008 13:52:30 -0000 Received: (qmail 28290 invoked by uid 22791); 26 Jun 2008 13:52:29 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 26 Jun 2008 13:51:51 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 113A098412; Thu, 26 Jun 2008 13:51:50 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id D94659835A; Thu, 26 Jun 2008 13:51:49 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KBrt7-0006oV-29; Thu, 26 Jun 2008 09:51:49 -0400 Date: Thu, 26 Jun 2008 14:12:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Add comments to linux-nat.c Message-ID: <20080626135149.GF22726@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200806141829.05646.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200806141829.05646.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00472.txt.bz2 On Sat, Jun 14, 2008 at 06:29:05PM +0400, Vladimir Prus wrote: > > With the introduction of async mode, linux-nat.c became even more complex that it > was, and it became apparent that some high-level comments are needed. So, I've grabbed > Pedro and Dan on IRC and extracted the knowledge from their heads into a text file. > Here's the result. OK? When you get a chance, could you repost this with Eli's comments addressed? Here's a few more but the content looks fine. > +/* This comments documents high-level logic of this file. This comment documents the, or These comments document the. > +blocked, the signal becomes pending and sigsuspend, presumably, immediately > +noticed it and returns. s/presumably, //. You're correct. Also noticed -> notices. > +The main design point is that every time GDB is outside linux-nat.c, we have a > +SIGCLD handler installed that is called when something happens to the target SIGCHLD -- Daniel Jacobowitz CodeSourcery