Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: make the remote target store thread ids in ptid_t.tid
Date: Thu, 26 Jun 2008 03:21:00 -0000	[thread overview]
Message-ID: <20080626022232.GA20206@caradoc.them.org> (raw)
In-Reply-To: <200806252351.59167.pedro@codesourcery.com>

On Wed, Jun 25, 2008 at 11:51:59PM +0100, Pedro Alves wrote:
> I've tested this extensivelly by talking to a native gdbserver,
> and native gdbserver with vCont disabled, and then also with a
> gdbserver with vCont and all thread related packets and fields
> disabled, to simulate old stubs and stubs that don't support
> threads at all.

These sound useful for testing.  Any interest in making them command
line options for gdbserver?

> 2008-06-25  Pedro Alves  <pedro@codesourcery.com>
> 
> 	Use ptid_t.tid to store thread ids instead of ptid_t.pid.
> 
> 	* remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): New
> 	globals.
> 	(general_thread, continue_thread): Change type to ptid_t.
> 	(record_currthread): Take a ptid_t parameter instead of an
> 	integer.
> 	(MAGIC_NULL_PID): Delete.
> 	(set_thread): Take a ptid_t parameter and adjust.
> 	(set_general_thread, set_continue_thread): New.
> 	(remote_thread_alive, remote_newthread_step)
> 	(remote_current_thread, remote_find_new_threads)
> 	(remote_threads_info, remote_start_remote, remote_vcont_resume)
> 	(remote_resume_1, remote_wait, extended_remote_create_inferior_1)
> 	(threadalive_test, remote_pid_to_str)
> 	(remote_get_thread_local_address): Adjust.
> 	(_initialize_remote): Initialize magic_null_ptid, not_sent_ptid
> 	and any_thread_ptid.

Looks OK to me.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-06-26  2:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 23:11 Pedro Alves
2008-06-26  3:21 ` Daniel Jacobowitz [this message]
2008-06-27 12:33   ` Pedro Alves
2008-06-27 13:26     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080626022232.GA20206@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox