From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18785 invoked by alias); 26 Jun 2008 02:22:58 -0000 Received: (qmail 18777 invoked by uid 22791); 26 Jun 2008 02:22:57 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 26 Jun 2008 02:22:35 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id B5F9998366; Thu, 26 Jun 2008 02:22:33 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 973499835A; Thu, 26 Jun 2008 02:22:33 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KBh84-0005Kq-VJ; Wed, 25 Jun 2008 22:22:32 -0400 Date: Thu, 26 Jun 2008 03:21:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: make the remote target store thread ids in ptid_t.tid Message-ID: <20080626022232.GA20206@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200806252351.59167.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200806252351.59167.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00463.txt.bz2 On Wed, Jun 25, 2008 at 11:51:59PM +0100, Pedro Alves wrote: > I've tested this extensivelly by talking to a native gdbserver, > and native gdbserver with vCont disabled, and then also with a > gdbserver with vCont and all thread related packets and fields > disabled, to simulate old stubs and stubs that don't support > threads at all. These sound useful for testing. Any interest in making them command line options for gdbserver? > 2008-06-25 Pedro Alves > > Use ptid_t.tid to store thread ids instead of ptid_t.pid. > > * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): New > globals. > (general_thread, continue_thread): Change type to ptid_t. > (record_currthread): Take a ptid_t parameter instead of an > integer. > (MAGIC_NULL_PID): Delete. > (set_thread): Take a ptid_t parameter and adjust. > (set_general_thread, set_continue_thread): New. > (remote_thread_alive, remote_newthread_step) > (remote_current_thread, remote_find_new_threads) > (remote_threads_info, remote_start_remote, remote_vcont_resume) > (remote_resume_1, remote_wait, extended_remote_create_inferior_1) > (threadalive_test, remote_pid_to_str) > (remote_get_thread_local_address): Adjust. > (_initialize_remote): Initialize magic_null_ptid, not_sent_ptid > and any_thread_ptid. Looks OK to me. -- Daniel Jacobowitz CodeSourcery