From: Pedro Alves <pedro@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [non-stop] 05/10 Refactor a bit infrun.c
Date: Wed, 25 Jun 2008 20:03:00 -0000 [thread overview]
Message-ID: <200806252022.03617.pedro@codesourcery.com> (raw)
In-Reply-To: <20080625191159.GC25575@caradoc.them.org>
A Wednesday 25 June 2008 20:11:59, Daniel Jacobowitz wrote:
> On Sun, Jun 15, 2008 at 10:04:43PM +0100, Pedro Alves wrote:
> > @@ -1491,13 +1510,16 @@ wait_for_inferior (int treat_exec_as_sig
> > void
> > fetch_inferior_event (void *client_data)
> > {
> > + struct execution_control_state ecss = ecss;
>
> Please don't use this - IIRC it's a GCC extension to shut up
> uninitialized variable warnings. If there are warnings without the
> initializer, just memset it.
Oh, shame on me, have no idea how that slipped there. :-( All the
vars in execution_control_state are always cleared in handle_inferior_event,
but it's just safer to memset it, or '= {0}' it, as you say.
Thanks a lot for the review.
--
Pedro Alves
next prev parent reply other threads:[~2008-06-25 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 21:05 Pedro Alves
2008-06-25 19:18 ` Daniel Jacobowitz
2008-06-25 20:03 ` Pedro Alves [this message]
2008-07-02 3:33 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806252022.03617.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox