From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1588 invoked by alias); 25 Jun 2008 19:22:25 -0000 Received: (qmail 1530 invoked by uid 22791); 25 Jun 2008 19:22:24 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jun 2008 19:22:07 +0000 Received: (qmail 11514 invoked from network); 25 Jun 2008 19:22:05 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 25 Jun 2008 19:22:05 -0000 From: Pedro Alves To: Daniel Jacobowitz Subject: Re: [non-stop] 05/10 Refactor a bit infrun.c Date: Wed, 25 Jun 2008 20:03:00 -0000 User-Agent: KMail/1.9.9 Cc: gdb-patches@sourceware.org References: <200806152204.44095.pedro@codesourcery.com> <20080625191159.GC25575@caradoc.them.org> In-Reply-To: <20080625191159.GC25575@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806252022.03617.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00450.txt.bz2 A Wednesday 25 June 2008 20:11:59, Daniel Jacobowitz wrote: > On Sun, Jun 15, 2008 at 10:04:43PM +0100, Pedro Alves wrote: > > @@ -1491,13 +1510,16 @@ wait_for_inferior (int treat_exec_as_sig > > void > > fetch_inferior_event (void *client_data) > > { > > + struct execution_control_state ecss = ecss; > > Please don't use this - IIRC it's a GCC extension to shut up > uninitialized variable warnings. If there are warnings without the > initializer, just memset it. Oh, shame on me, have no idea how that slipped there. :-( All the vars in execution_control_state are always cleared in handle_inferior_event, but it's just safer to memset it, or '= {0}' it, as you say. Thanks a lot for the review. -- Pedro Alves