From: Pedro Alves <pedro@codesourcery.com>
To: luisgpm@linux.vnet.ibm.com
Cc: Daniel Jacobowitz <drow@false.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] PPC - Stepping off breakpoints in non-stop mode
Date: Tue, 24 Jun 2008 18:08:00 -0000 [thread overview]
Message-ID: <200806241503.59231.pedro@codesourcery.com> (raw)
In-Reply-To: <1212768014.10042.60.camel@gargoyle>
A Friday 06 June 2008 17:00:14, Luis Machado wrote:
> On Thu, 2008-06-05 at 16:02 -0400, Daniel Jacobowitz wrote:
> > Sorry, the problem Pedro spotted is still there :-(
>
> How about the attached one?
>
FWIW, I'm happy with this version.
> + if ((opcode == B_INSN) || (opcode == BC_INSN) || (opcode == BXL_INSN))
Strictly speaking, the extra parens violate the GNU coding
conventions, as they aren't really needed here.
> + if (link_register_bit)
> + {
> +
> + regcache_cooked_write_unsigned (regs,
Unneeded extra blank line here.
--
Pedro Alves
next prev parent reply other threads:[~2008-06-24 14:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 20:26 Luis Machado
2008-05-19 15:20 ` Pedro Alves
2008-05-19 15:21 ` Luis Machado
2008-05-29 15:41 ` Luis Machado
2008-06-05 20:03 ` Daniel Jacobowitz
2008-06-06 16:00 ` Luis Machado
2008-06-24 14:59 ` Luis Machado
2008-06-24 18:08 ` Pedro Alves [this message]
2008-06-24 18:19 ` Luis Machado
2008-06-25 12:54 ` Joel Brobecker
2008-06-25 13:35 ` Luis Machado
2008-06-25 13:51 ` Joel Brobecker
2008-06-25 15:48 ` Luis Machado
2008-06-25 18:49 ` Joel Brobecker
2008-06-30 17:04 ` Luis Machado
2008-05-19 15:20 ` Luis Machado
2008-07-08 1:39 Jonathan Larmour
2008-07-08 3:53 ` Luis Machado
2008-07-08 14:59 ` Jonathan Larmour
2008-07-08 15:13 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806241503.59231.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox