From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14145 invoked by alias); 24 Jun 2008 14:04:22 -0000 Received: (qmail 14133 invoked by uid 22791); 24 Jun 2008 14:04:19 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Jun 2008 14:04:02 +0000 Received: (qmail 8308 invoked from network); 24 Jun 2008 14:04:00 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Jun 2008 14:04:00 -0000 From: Pedro Alves To: luisgpm@linux.vnet.ibm.com Subject: Re: [PATCH] PPC - Stepping off breakpoints in non-stop mode Date: Tue, 24 Jun 2008 18:08:00 -0000 User-Agent: KMail/1.9.9 Cc: Daniel Jacobowitz , gdb-patches@sourceware.org References: <1209753019.7131.29.camel@gargoyle> <20080605200249.GH25085@caradoc.them.org> <1212768014.10042.60.camel@gargoyle> In-Reply-To: <1212768014.10042.60.camel@gargoyle> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806241503.59231.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00409.txt.bz2 A Friday 06 June 2008 17:00:14, Luis Machado wrote: > On Thu, 2008-06-05 at 16:02 -0400, Daniel Jacobowitz wrote: > > Sorry, the problem Pedro spotted is still there :-( > > How about the attached one? > FWIW, I'm happy with this version. > + if ((opcode == B_INSN) || (opcode == BC_INSN) || (opcode == BXL_INSN)) Strictly speaking, the extra parens violate the GNU coding conventions, as they aren't really needed here. > + if (link_register_bit) > + { > + > + regcache_cooked_write_unsigned (regs, Unneeded extra blank line here. -- Pedro Alves