From: Daniel Jacobowitz <drow@false.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: fix two field name completion bugs
Date: Mon, 09 Jun 2008 19:15:00 -0000 [thread overview]
Message-ID: <20080609184545.GB1378@caradoc.them.org> (raw)
In-Reply-To: <m33ann93c7.fsf@fleche.redhat.com>
On Sun, Jun 08, 2008 at 12:41:28PM -0600, Tom Tromey wrote:
> ChangeLog:
> 2008-06-08 Tom Tromey <tromey@redhat.com>
>
> * completer.c (complete_line): Don't special-case
> expression_completer.
> (expression_completer): Only pass last word to
> location_completer.
> * c-exp.y (yylex): Check 'token', not 'operator'.
This part is OK.
> +send_gdb "p values\[0\] . a\t"
> +sleep 3
> +gdb_expect {
I know there's other tests in completion.exp that do this but are the
sleeps really necessary? Anywhere that we sleep, the testsuite
becomes timing sensitive - not to mention slow.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-06-09 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 18:41 Tom Tromey
2008-06-09 19:15 ` Daniel Jacobowitz [this message]
2008-06-09 19:26 ` Tom Tromey
2008-06-09 22:40 ` Daniel Jacobowitz
2008-06-09 22:50 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609184545.GB1378@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox