From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1658 invoked by alias); 9 Jun 2008 18:46:09 -0000 Received: (qmail 1647 invoked by uid 22791); 9 Jun 2008 18:46:07 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 09 Jun 2008 18:45:48 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D6C0D9840C; Mon, 9 Jun 2008 18:45:46 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 8C3D098402; Mon, 9 Jun 2008 18:45:46 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1K5mNF-0000Rg-6p; Mon, 09 Jun 2008 14:45:45 -0400 Date: Mon, 09 Jun 2008 19:15:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: fix two field name completion bugs Message-ID: <20080609184545.GB1378@caradoc.them.org> Mail-Followup-To: Tom Tromey , gdb-patches@sources.redhat.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00170.txt.bz2 On Sun, Jun 08, 2008 at 12:41:28PM -0600, Tom Tromey wrote: > ChangeLog: > 2008-06-08 Tom Tromey > > * completer.c (complete_line): Don't special-case > expression_completer. > (expression_completer): Only pass last word to > location_completer. > * c-exp.y (yylex): Check 'token', not 'operator'. This part is OK. > +send_gdb "p values\[0\] . a\t" > +sleep 3 > +gdb_expect { I know there's other tests in completion.exp that do this but are the sleeps really necessary? Anywhere that we sleep, the testsuite becomes timing sensitive - not to mention slow. -- Daniel Jacobowitz CodeSourcery