Re: --with-pkgversion and --with-bugurl support for GDB

[Daniel Jacobowitz <drow@false.org>]

On Tue, May 20, 2008 at 04:09:26PM +0000, Joseph S. Myers wrote:
> On Tue, 20 May 2008, Eli Zaretskii wrote:
> 
> > Sorry, I don't agree.  I think the manual should have clear
> > instructions on how to report bugs efficiently.  I don't like to ask
> > users to study Web pages to know that when they are already reading
> > documentation.
> > 
> > I don't mind removing obsolete information, but please either update
> > the rest to talk about bug-gdb and gdb@sources.redhat.com, or leave it
> > intact and I will get to updating it when I have time.
> 
> This version keeps the original text if the default BUGURL value is
> used.  Tested with and without --with-bugurl use.  OK to commit?

Issues I found:

  - There's an #ifdef, but we define it unconditionally.

  - You added the defines to the GCC command line for all files, but
  only a small handfull (currently two) need them.  If the quoting
  makes it difficult to stuff them into config.h, I'd rather they were
  only passed to those two files.  It may be easier to put them in
  config.h, I'm not sure.

Otherwise, looks OK.  Thanks.

-- 
Daniel Jacobowitz
CodeSourcery