From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15263 invoked by alias); 5 Jun 2008 20:24:55 -0000 Received: (qmail 15255 invoked by uid 22791); 5 Jun 2008 20:24:54 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 05 Jun 2008 20:24:35 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 05E1498371 for ; Thu, 5 Jun 2008 20:24:33 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id A81809809F for ; Thu, 5 Jun 2008 20:24:32 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1K4M0d-0000rh-U2 for gdb-patches@sourceware.org; Thu, 05 Jun 2008 16:24:31 -0400 Date: Thu, 05 Jun 2008 20:24:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: --with-pkgversion and --with-bugurl support for GDB Message-ID: <20080605202431.GK25085@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00070.txt.bz2 On Tue, May 20, 2008 at 04:09:26PM +0000, Joseph S. Myers wrote: > On Tue, 20 May 2008, Eli Zaretskii wrote: > > > Sorry, I don't agree. I think the manual should have clear > > instructions on how to report bugs efficiently. I don't like to ask > > users to study Web pages to know that when they are already reading > > documentation. > > > > I don't mind removing obsolete information, but please either update > > the rest to talk about bug-gdb and gdb@sources.redhat.com, or leave it > > intact and I will get to updating it when I have time. > > This version keeps the original text if the default BUGURL value is > used. Tested with and without --with-bugurl use. OK to commit? Issues I found: - There's an #ifdef, but we define it unconditionally. - You added the defines to the GCC command line for all files, but only a small handfull (currently two) need them. If the quoting makes it difficult to stuff them into config.h, I'd rather they were only passed to those two files. It may be easier to put them in config.h, I'm not sure. Otherwise, looks OK. Thanks. -- Daniel Jacobowitz CodeSourcery