[ob] Testsuite longjmp.exp race

[ob] Testsuite longjmp.exp race

[Jan Kratochvil]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

Hi,

with slow GDB the testcase will ERROR-out.
(GDB_TEST does not need $gdb_prompt but GDB_TEST_MULTIPLE does)

Regards,
Jan

 delete breakpoints
 (gdb) delete breakpoints
 Delete all breakpoints? (y or n) y
-(gdb) info breakpoints
-No breakpoints or watchpoints.
-(gdb) break 76
+Please answer y or n.
+Delete all breakpoints? (y or n) y
+(gdb) y
+Undefined command: "y".  Try "help".
+(gdb) ERROR: breakpoints not deleted
+break 76
 Breakpoint 6 at 0x400625: file ../.././gdb/testsuite/gdb.base/longjmp.c, line 76.
-(gdb) PASS: gdb.base/longjmp.exp: breakpoint at pattern 3 start
+(gdb) UNRESOLVED: gdb.base/longjmp.exp: breakpoint at pattern 3 start

[-- Attachment #2: gdb-longjmp-test-race.patch --]
[-- Type: text/plain, Size: 1118 bytes --]

2008-05-22  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.base/longjmp.exp: Fix GDB_TEST_MULTIPLE missing GDB_PROMPT races.

--- ./gdb/testsuite/gdb.base/longjmp.exp	4 May 2008 19:43:31 -0000	1.1
+++ ./gdb/testsuite/gdb.base/longjmp.exp	22 May 2008 14:22:36 -0000
@@ -75,12 +75,12 @@ gdb_test "next" "longjmp \\(env, 1\\);.*
 
 set msg "next over longjmp(1)"
 gdb_test_multiple "next" $msg {
-    -re ".*patt1.*" {
+    -re ".*patt1.*$gdb_prompt $" {
 	pass $msg
 	gdb_test "next" "resumes\\+\\+.*" "next into else block (1)"
 	gdb_test "next" "miss_step_1.*" "next into safety net (1)"
     }
-    -re "miss_step_1.*" {
+    -re "miss_step_1.*$gdb_prompt $" {
 	fail $msg
     }
 }
@@ -105,13 +105,13 @@ gdb_test "next" "call_longjmp.*" "next o
 
 set msg "next over call_longjmp (2)"
 gdb_test_multiple "next" $msg {
-    -re ".*patt2.*" {
+    -re ".*patt2.*$gdb_prompt $" {
 	pass $msg
 
 	gdb_test "next" "resumes\\+\\+.*" "next into else block (2)"
 	gdb_test "next" "miss_step_2.*" "next into safety net (2)"
     }
-    -re "miss_step_2.*" {
+    -re "miss_step_2.*$gdb_prompt $" {
 	fail $msg
     }
 }

Re: [ob] Testsuite longjmp.exp race

[Pedro Alves]

A Thursday 22 May 2008 15:34:20, Jan Kratochvil wrote:
> Hi,
>
> with slow GDB the testcase will ERROR-out.
> (GDB_TEST does not need $gdb_prompt but GDB_TEST_MULTIPLE does)
>

Thanks!

-- 
Pedro Alves