From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: dj@redhat.com (DJ Delorie)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc/rft] Update remaining targets to value-based unwinding
Date: Tue, 20 May 2008 15:17:00 -0000 [thread overview]
Message-ID: <200805192246.m4JMkIbT013522@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200805192202.m4JM2WLP015447@greed.delorie.com> from "DJ Delorie" at May 19, 2008 06:02:32 PM
DJ Delorie wrote:
> > > m32c (two multilibs):
> > >
> > > # of expected passes 17068
> > > # of unexpected failures 2758
> >
> > In particular, this result looks a bit worrisome ...
>
> It's bad. The m32c is a weird chip (two stack pointers, 24 bit
> addresses), it will probably need Jim or Kevin to massage your patch
> to get it to work.
Ah, I see I made an obvious mistake in the m32c conversion.
Would you mind testing again with the following additional patch?
Thanks,
Ulrich
diff -urNp gdb-orig/gdb/m32c-tdep.c gdb-head/gdb/m32c-tdep.c
--- gdb-orig/gdb/m32c-tdep.c 2008-05-20 00:41:46.000000000 +0200
+++ gdb-head/gdb/m32c-tdep.c 2008-05-20 00:42:23.000000000 +0200
@@ -1919,7 +1919,7 @@ m32c_prev_register (struct frame_info *t
return a description of the stack slot holding it. */
if (p->reg_offset[regnum] != 1)
return frame_unwind_got_memory (this_frame, regnum,
- p->reg_offset[regnum]);
+ frame_base + p->reg_offset[regnum]);
/* Otherwise, presume we haven't changed the value of this
register, and get it from the next frame. */
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2008-05-19 22:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 15:16 Ulrich Weigand
2008-05-20 3:53 ` DJ Delorie
2008-05-20 7:54 ` Ulrich Weigand
2008-05-20 15:15 ` DJ Delorie
2008-05-20 15:17 ` Ulrich Weigand [this message]
2008-05-20 15:21 ` DJ Delorie
2008-05-30 11:19 ` Daniel Jacobowitz
2008-05-30 12:00 ` Mark Kettenis
2008-06-28 16:46 ` Daniel Jacobowitz
2008-06-28 17:44 ` Ulrich Weigand
2008-06-29 0:42 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805192246.m4JMkIbT013522@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=dj@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox