From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15399 invoked by alias); 19 May 2008 22:46:49 -0000 Received: (qmail 15389 invoked by uid 22791); 19 May 2008 22:46:49 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 19 May 2008 22:46:24 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m4JMkJPt121616 for ; Mon, 19 May 2008 22:46:19 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m4JMkIrr1691768 for ; Tue, 20 May 2008 00:46:18 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m4JMkIst013525 for ; Tue, 20 May 2008 00:46:18 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m4JMkIbT013522; Tue, 20 May 2008 00:46:18 +0200 Message-Id: <200805192246.m4JMkIbT013522@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 20 May 2008 00:46:18 +0200 Subject: Re: [rfc/rft] Update remaining targets to value-based unwinding To: dj@redhat.com (DJ Delorie) Date: Tue, 20 May 2008 15:17:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <200805192202.m4JM2WLP015447@greed.delorie.com> from "DJ Delorie" at May 19, 2008 06:02:32 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00585.txt.bz2 DJ Delorie wrote: > > > m32c (two multilibs): > > > > > > # of expected passes 17068 > > > # of unexpected failures 2758 > > > > In particular, this result looks a bit worrisome ... > > It's bad. The m32c is a weird chip (two stack pointers, 24 bit > addresses), it will probably need Jim or Kevin to massage your patch > to get it to work. Ah, I see I made an obvious mistake in the m32c conversion. Would you mind testing again with the following additional patch? Thanks, Ulrich diff -urNp gdb-orig/gdb/m32c-tdep.c gdb-head/gdb/m32c-tdep.c --- gdb-orig/gdb/m32c-tdep.c 2008-05-20 00:41:46.000000000 +0200 +++ gdb-head/gdb/m32c-tdep.c 2008-05-20 00:42:23.000000000 +0200 @@ -1919,7 +1919,7 @@ m32c_prev_register (struct frame_info *t return a description of the stack slot holding it. */ if (p->reg_offset[regnum] != 1) return frame_unwind_got_memory (this_frame, regnum, - p->reg_offset[regnum]); + frame_base + p->reg_offset[regnum]); /* Otherwise, presume we haven't changed the value of this register, and get it from the next frame. */ -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com