From: Daniel Jacobowitz <drow@false.org>
To: Alan Modra <amodra@bigpond.net.au>
Cc: gdb-patches@sourceware.org
Subject: Re: dbxread.c warning fix
Date: Thu, 15 May 2008 16:51:00 -0000 [thread overview]
Message-ID: <20080515120729.GA7597@caradoc.them.org> (raw)
In-Reply-To: <20080515005352.GC11328@bubble.grove.modra.org>
On Thu, May 15, 2008 at 10:23:52AM +0930, Alan Modra wrote:
> Some recent versions of gcc warn that passing nlist to set_namestring
> results in uninitialised memory access. The warning is correct since
> n_other isn't initialised and the whole struct is passed by copying to
> set_namestring. This belts and braces patch corrects
> INTERNALIZE_SYMBOL to init n_other, and changes set_namestring to take
> a pointer arg. OK to apply?
>
> * dbxread.c: Formatting.
> (INTERNALIZE_SYMBOL): Init n_other.
> (set_namestring): Take pointer to nlist arg rather than struct
> copy. Update all callers.
OK, thanks.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-05-15 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 16:06 Alan Modra
2008-05-15 16:51 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515120729.GA7597@caradoc.them.org \
--to=drow@false.org \
--cc=amodra@bigpond.net.au \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox