From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7289 invoked by alias); 15 May 2008 12:08:56 -0000 Received: (qmail 7279 invoked by uid 22791); 15 May 2008 12:08:55 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 15 May 2008 12:08:33 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 798EE983D6 for ; Thu, 15 May 2008 12:08:30 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 4C6679830E for ; Thu, 15 May 2008 12:07:30 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JwcF7-00023Y-FC; Thu, 15 May 2008 08:07:29 -0400 Date: Thu, 15 May 2008 16:51:00 -0000 From: Daniel Jacobowitz To: Alan Modra Cc: gdb-patches@sourceware.org Subject: Re: dbxread.c warning fix Message-ID: <20080515120729.GA7597@caradoc.them.org> Mail-Followup-To: Alan Modra , gdb-patches@sourceware.org References: <20080515005352.GC11328@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080515005352.GC11328@bubble.grove.modra.org> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00462.txt.bz2 On Thu, May 15, 2008 at 10:23:52AM +0930, Alan Modra wrote: > Some recent versions of gcc warn that passing nlist to set_namestring > results in uninitialised memory access. The warning is correct since > n_other isn't initialised and the whole struct is passed by copying to > set_namestring. This belts and braces patch corrects > INTERNALIZE_SYMBOL to init n_other, and changes set_namestring to take > a pointer arg. OK to apply? > > * dbxread.c: Formatting. > (INTERNALIZE_SYMBOL): Init n_other. > (set_namestring): Take pointer to nlist arg rather than struct > copy. Update all callers. OK, thanks. -- Daniel Jacobowitz CodeSourcery