[PATCH]: Remove sparc-linux long double size override.

[PATCH]: Remove sparc-linux long double size override.

[David Miller]

We realized many years ago that using 64-bit long doubles
for 32-bit sparc was a mistake and migrated all of userland
over to using proper 128-bit long doubles.

There isn't a way to really detect this at run time, but I
think it's better to move forward and delete this override
and get current systems right rather than support ancient
ones.

This fixes another swath of testsuite failures.

Ok to apply?

2008-05-11  David S. Miller  <davem@davemloft.net>

	* sparc-linux-tdep.c (sparc32_linux_init_abi): Remove
	long double size override, Linux does use 128-bit now.

Index: gdb/sparc-linux-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sparc-linux-tdep.c,v
retrieving revision 1.27
diff -u -r1.27 sparc-linux-tdep.c
--- gdb/sparc-linux-tdep.c	11 May 2008 22:10:30 -0000	1.27
+++ gdb/sparc-linux-tdep.c	11 May 2008 22:16:42 -0000
@@ -264,10 +264,6 @@
      prologue analysis.  */
   tdep->plt_entry_size = 12;
 
-  /* GNU/Linux doesn't support the 128-bit `long double' from the psABI.  */
-  set_gdbarch_long_double_bit (gdbarch, 64);
-  set_gdbarch_long_double_format (gdbarch, floatformats_ieee_double);
-
   /* Enable TLS support.  */
   set_gdbarch_fetch_tls_load_module_address (gdbarch,
                                              svr4_fetch_objfile_link_map);

Re: [PATCH]: Remove sparc-linux long double size override.

[Daniel Jacobowitz]

On Sun, May 11, 2008 at 03:19:40PM -0700, David Miller wrote:
> There isn't a way to really detect this at run time, but I
> think it's better to move forward and delete this override
> and get current systems right rather than support ancient
> ones.

FWIW, GDB will still mostly work with 64-bit long double once this is
applied (we went through the same thing for PPC).  It will just be a
little confused because the type "long double" from debug info will
appear to be a double instead.

> Ok to apply?
> 
> 2008-05-11  David S. Miller  <davem@davemloft.net>
> 
> 	* sparc-linux-tdep.c (sparc32_linux_init_abi): Remove
> 	long double size override, Linux does use 128-bit now.

Yes, this is fine.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [PATCH]: Remove sparc-linux long double size override.

[David Miller]

From: Daniel Jacobowitz <drow@false.org>
Date: Sun, 11 May 2008 18:26:05 -0400

> On Sun, May 11, 2008 at 03:19:40PM -0700, David Miller wrote:
> > There isn't a way to really detect this at run time, but I
> > think it's better to move forward and delete this override
> > and get current systems right rather than support ancient
> > ones.
> 
> FWIW, GDB will still mostly work with 64-bit long double once this is
> applied (we went through the same thing for PPC).  It will just be a
> little confused because the type "long double" from debug info will
> appear to be a double instead.

Thanks for the info, I didn't know that.

> > Ok to apply?
> > 
> > 2008-05-11  David S. Miller  <davem@davemloft.net>
> > 
> > 	* sparc-linux-tdep.c (sparc32_linux_init_abi): Remove
> > 	long double size override, Linux does use 128-bit now.
> 
> Yes, this is fine.

Installed, thanks for reviewing.