Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: uweigand@de.ibm.com (Ulrich Weigand)
Cc: drow@false.org (Daniel Jacobowitz), gdb-patches@sourceware.org
Subject: Re: [rfa, v3] Fix inferior calls during interrupted system calls        on PowerPC
Date: Sun, 11 May 2008 20:04:00 -0000	[thread overview]
Message-ID: <200805111531.m4BFVVJg000341@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200805031719.m43HJ6CL011158@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at May 03, 2008 07:19:06 PM

> Daniel Jacobowitz wrote:
> 
> > On Sat, May 03, 2008 at 05:31:35PM +0200, Ulrich Weigand wrote:
> > > - Should we attempt to detect SPE registers in core files?
> > 
> > I don't know how SPE registers are dumped, offhand.  We can fix this
> > up later.
> > 
> > The patch looks OK to me.
> 
> Thanks!  I've checked it in now.

Unfortunately I forgot to port one aspect of the mips-linux implementation:
common ppc code needs to pass tdesc_data to the osabi handler in the first
place.  Due to this oversight, the new ppc_linux_init_abi code didn't
actually do anything.  I'm somewhat surprised that it still appeared to
work ...

Anyway, this patch adds the missing piece: rs6000_gdbarch_init now passed
in the target description (and architecture-specific part) via the
info.tdep_info hook, similar to mips.

Tested on powerpc-linux and powerpc64-linux, both native and using local
gdbserver mode.  No change to the test results.

Committed to mainline.

Bye,
Ulrich


ChangeLog:

	* rs6000-tdep.c (rs6000_gdbarch_init): Set up info.target_desc
	and info.tdep_info before calling gdbarch_init_osabi.

diff -urNp gdb-orig/gdb/rs6000-tdep.c gdb-head/gdb/rs6000-tdep.c
--- gdb-orig/gdb/rs6000-tdep.c	2008-05-04 02:08:56.000000000 +0200
+++ gdb-head/gdb/rs6000-tdep.c	2008-05-11 16:34:52.034490706 +0200
@@ -3171,6 +3171,8 @@ rs6000_gdbarch_init (struct gdbarch_info
   dwarf2_frame_set_init_reg (gdbarch, ppc_dwarf2_frame_init_reg);
 
   /* Hook in ABI-specific overrides, if they have been registered.  */
+  info.target_desc = tdesc;
+  info.tdep_info = (void *) tdesc_data;
   gdbarch_init_osabi (info, gdbarch);
 
   switch (info.osabi)

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


      reply	other threads:[~2008-05-11 15:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27 19:34 [rfc] " Ulrich Weigand
2008-04-25 16:16 ` [rfa, v2] " Ulrich Weigand
2008-05-02 14:38   ` Daniel Jacobowitz
2008-05-03 15:55     ` [rfa, v3] " Ulrich Weigand
2008-05-03 16:19       ` Daniel Jacobowitz
2008-05-03 19:56         ` Ulrich Weigand
2008-05-11 20:04           ` Ulrich Weigand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805111531.m4BFVVJg000341@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox