From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12013 invoked by alias); 11 May 2008 15:32:28 -0000 Received: (qmail 12004 invoked by uid 22791); 11 May 2008 15:32:28 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 11 May 2008 15:32:04 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id m4BFVVS6241280 for ; Sun, 11 May 2008 15:31:31 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m4BFVVPJ4362304 for ; Sun, 11 May 2008 17:31:31 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m4BFVVxe000344 for ; Sun, 11 May 2008 17:31:31 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m4BFVVJg000341; Sun, 11 May 2008 17:31:31 +0200 Message-Id: <200805111531.m4BFVVJg000341@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Sun, 11 May 2008 17:31:31 +0200 Subject: Re: [rfa, v3] Fix inferior calls during interrupted system calls on PowerPC To: uweigand@de.ibm.com (Ulrich Weigand) Date: Sun, 11 May 2008 20:04:00 -0000 From: "Ulrich Weigand" Cc: drow@false.org (Daniel Jacobowitz), gdb-patches@sourceware.org In-Reply-To: <200805031719.m43HJ6CL011158@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at May 03, 2008 07:19:06 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00357.txt.bz2 > Daniel Jacobowitz wrote: > > > On Sat, May 03, 2008 at 05:31:35PM +0200, Ulrich Weigand wrote: > > > - Should we attempt to detect SPE registers in core files? > > > > I don't know how SPE registers are dumped, offhand. We can fix this > > up later. > > > > The patch looks OK to me. > > Thanks! I've checked it in now. Unfortunately I forgot to port one aspect of the mips-linux implementation: common ppc code needs to pass tdesc_data to the osabi handler in the first place. Due to this oversight, the new ppc_linux_init_abi code didn't actually do anything. I'm somewhat surprised that it still appeared to work ... Anyway, this patch adds the missing piece: rs6000_gdbarch_init now passed in the target description (and architecture-specific part) via the info.tdep_info hook, similar to mips. Tested on powerpc-linux and powerpc64-linux, both native and using local gdbserver mode. No change to the test results. Committed to mainline. Bye, Ulrich ChangeLog: * rs6000-tdep.c (rs6000_gdbarch_init): Set up info.target_desc and info.tdep_info before calling gdbarch_init_osabi. diff -urNp gdb-orig/gdb/rs6000-tdep.c gdb-head/gdb/rs6000-tdep.c --- gdb-orig/gdb/rs6000-tdep.c 2008-05-04 02:08:56.000000000 +0200 +++ gdb-head/gdb/rs6000-tdep.c 2008-05-11 16:34:52.034490706 +0200 @@ -3171,6 +3171,8 @@ rs6000_gdbarch_init (struct gdbarch_info dwarf2_frame_set_init_reg (gdbarch, ppc_dwarf2_frame_init_reg); /* Hook in ABI-specific overrides, if they have been registered. */ + info.target_desc = tdesc; + info.tdep_info = (void *) tdesc_data; gdbarch_init_osabi (info, gdbarch); switch (info.osabi) -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com