From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix calls to frame_base_find_by_frame in frame.c (?)
Date: Fri, 09 May 2008 04:06:00 -0000 [thread overview]
Message-ID: <20080509023436.GA25659@caradoc.them.org> (raw)
In-Reply-To: <20080509022413.GO7421@adacore.com>
On Thu, May 08, 2008 at 07:24:13PM -0700, Joel Brobecker wrote:
> Hi Daniel,
>
> I noticed a regression while converting alpha-osf to the value-based
> unwinding approach, and it looks like frame_base_find_by_frame was
> changed to take a this_frame but the callers were still left passing
> a next_frame. As a result, we ended up selecting the wrong frame
> base unwinder for a one of our frames, leading to the wrong value
> being printed for the one argument.
>
> 2008-05-08 Joel Brobecker <brobecker@adacore.com>
>
> * frame.c (get_frame_base_address, get_frame_locals_address)
> (get_frame_args_address): Pass the correct frame when calling
> frame_base_find_by_frame.
Yes, you're right. OK, thanks.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-05-09 2:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 4:04 Joel Brobecker
2008-05-09 4:06 ` Daniel Jacobowitz [this message]
2008-05-09 7:45 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080509023436.GA25659@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox