From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11274 invoked by alias); 9 May 2008 02:35:13 -0000 Received: (qmail 11264 invoked by uid 22791); 9 May 2008 02:35:12 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 May 2008 02:34:40 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 23DA6983F1; Fri, 9 May 2008 02:34:39 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 065C398011; Fri, 9 May 2008 02:34:36 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JuIRQ-0006hl-6K; Thu, 08 May 2008 22:34:36 -0400 Date: Fri, 09 May 2008 04:06:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix calls to frame_base_find_by_frame in frame.c (?) Message-ID: <20080509023436.GA25659@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20080509022413.GO7421@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080509022413.GO7421@adacore.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00304.txt.bz2 On Thu, May 08, 2008 at 07:24:13PM -0700, Joel Brobecker wrote: > Hi Daniel, > > I noticed a regression while converting alpha-osf to the value-based > unwinding approach, and it looks like frame_base_find_by_frame was > changed to take a this_frame but the callers were still left passing > a next_frame. As a result, we ended up selecting the wrong frame > base unwinder for a one of our frames, leading to the wrong value > being printed for the one argument. > > 2008-05-08 Joel Brobecker > > * frame.c (get_frame_base_address, get_frame_locals_address) > (get_frame_args_address): Pass the correct frame when calling > frame_base_find_by_frame. Yes, you're right. OK, thanks. -- Daniel Jacobowitz CodeSourcery