Re: [rfa] gdbserver multiple register set issue: PBUFSIZ

[Daniel Jacobowitz <drow@false.org>]

On Thu, May 08, 2008 at 08:28:52PM +0200, Ulrich Weigand wrote:
> I guess one way to fix this would be to have GDB issue another qSupported
> query after it re-attaches.  On the other hand, I'm not sure why this
> parameter is even limited by the register set size: when transferring
> memory or files (or other data like XML feature descriptions), allowing
> larger packet sizes would be helpful even on platforms where the register
> set is small.

Right.  It used to be that PBUFSIZ was much larger than any packet
we'd have reason to send except for g/G, but that's not true any more;
now there's bulk memory transfers and XML.

> As GDB limits the packet size to 16 KB anyway, I'd propose to simply
> always use 16 KB as PBUFSIZ as well.  The patch below implements this
> (together with a sanity check that register packets still fit).
> 
> Tested on powerpc-linux and powerpc64-linux in local gdbserver mode.
> 
> What do you think?   OK for mainline?

OK, thanks.

-- 
Daniel Jacobowitz
CodeSourcery