From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21500 invoked by alias); 8 May 2008 18:58:17 -0000 Received: (qmail 21449 invoked by uid 22791); 8 May 2008 18:58:16 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 May 2008 18:57:53 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 5B810983F1; Thu, 8 May 2008 18:57:52 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 44DE398011; Thu, 8 May 2008 18:57:52 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JuBJP-0008HL-HQ; Thu, 08 May 2008 14:57:51 -0400 Date: Thu, 08 May 2008 20:33:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfa] gdbserver multiple register set issue: PBUFSIZ Message-ID: <20080508185751.GA31519@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <200805081828.m48ISqlb004187@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200805081828.m48ISqlb004187@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00288.txt.bz2 On Thu, May 08, 2008 at 08:28:52PM +0200, Ulrich Weigand wrote: > I guess one way to fix this would be to have GDB issue another qSupported > query after it re-attaches. On the other hand, I'm not sure why this > parameter is even limited by the register set size: when transferring > memory or files (or other data like XML feature descriptions), allowing > larger packet sizes would be helpful even on platforms where the register > set is small. Right. It used to be that PBUFSIZ was much larger than any packet we'd have reason to send except for g/G, but that's not true any more; now there's bulk memory transfers and XML. > As GDB limits the packet size to 16 KB anyway, I'd propose to simply > always use 16 KB as PBUFSIZ as well. The patch below implements this > (together with a sanity check that register packets still fit). > > Tested on powerpc-linux and powerpc64-linux in local gdbserver mode. > > What do you think? OK for mainline? OK, thanks. -- Daniel Jacobowitz CodeSourcery