From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: expressions with C preprocessor macro info
Date: Sat, 03 May 2008 20:40:00 -0000 [thread overview]
Message-ID: <20080503202744.GA22625@caradoc.them.org> (raw)
In-Reply-To: <200805032119.27919.pedro@codesourcery.com>
On Sat, May 03, 2008 at 09:19:27PM +0100, Pedro Alves wrote:
> 2008-05-03 Pedro Alves <pedro@codesourcery.com>
>
> gdb/
> * parse.c (parse_exp_in_context): Don't override
> expression_context_pc if get_selected_block returned a valid block.
>
> gdb/testsuite/
> * gdb.base/macscp.exp, gdb.base/macscp1.c: Add test for printing
> expressions with macros.
This patch is OK since it's clearly progress. But doesn't this mean
that we should be passing a PC to parse_exp_1, not a block? Otherwise
macros will not be correct in e.g. breakpoint conditions:
loc->cond =
parse_exp_1 (&arg, block_for_pc (loc->address), 0);
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-05-03 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 20:38 Pedro Alves
2008-05-03 20:40 ` Daniel Jacobowitz [this message]
2008-05-03 23:27 ` Pedro Alves
2008-06-05 16:27 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080503202744.GA22625@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox