From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21926 invoked by alias); 3 May 2008 20:28:08 -0000 Received: (qmail 21910 invoked by uid 22791); 3 May 2008 20:28:07 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 03 May 2008 20:27:47 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0F2AC983D9; Sat, 3 May 2008 20:27:45 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id E163698150; Sat, 3 May 2008 20:27:44 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JsOKe-0005tc-8Y; Sat, 03 May 2008 16:27:44 -0400 Date: Sat, 03 May 2008 20:40:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: expressions with C preprocessor macro info Message-ID: <20080503202744.GA22625@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200805032119.27919.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200805032119.27919.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00139.txt.bz2 On Sat, May 03, 2008 at 09:19:27PM +0100, Pedro Alves wrote: > 2008-05-03 Pedro Alves > > gdb/ > * parse.c (parse_exp_in_context): Don't override > expression_context_pc if get_selected_block returned a valid block. > > gdb/testsuite/ > * gdb.base/macscp.exp, gdb.base/macscp1.c: Add test for printing > expressions with macros. This patch is OK since it's clearly progress. But doesn't this mean that we should be passing a PC to parse_exp_1, not a block? Otherwise macros will not be correct in e.g. breakpoint conditions: loc->cond = parse_exp_1 (&arg, block_for_pc (loc->address), 0); -- Daniel Jacobowitz CodeSourcery