From: Vladimir Prus <vladimir@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>, Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Remove command_line_handler_continuation.
Date: Sat, 03 May 2008 16:42:00 -0000 [thread overview]
Message-ID: <200805031958.39818.vladimir@codesourcery.com> (raw)
In-Reply-To: <20080502150314.GL29202@caradoc.them.org>
On Friday 02 May 2008 19:03:14 Daniel Jacobowitz wrote:
> On Thu, Apr 24, 2008 at 07:33:40PM +0300, Vladimir Prus wrote:
> >
> > With my previous patch to move all bpstat_do_actions calls into
> > event handler, all that command_line_handler_continuation does
> > is to print timings, if those are enabled. However, those timings
> > don't make much sense. Timings are good for debugging GDB performance,
> > and in case of command_line_handler_continuation, the times will report
> > the time when the application run.
> >
> > So, this patch removes that continuation. OK?
>
> OK once you and Eli agree about documenting the timings.
Here's a revision with doc clarification. Eli, does it look sufficient?
- Volodya
next prev parent reply other threads:[~2008-05-03 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 23:04 Vladimir Prus
2008-04-25 1:23 ` Eli Zaretskii
2008-04-26 13:24 ` Vladimir Prus
2008-04-26 13:41 ` Eli Zaretskii
2008-04-26 14:00 ` Vladimir Prus
2008-04-26 16:42 ` Eli Zaretskii
2008-05-02 15:18 ` Daniel Jacobowitz
2008-05-03 16:42 ` Vladimir Prus [this message]
2008-05-03 18:06 ` Vladimir Prus
2008-05-03 20:19 ` Eli Zaretskii
2008-05-03 20:28 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805031958.39818.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox