From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6545 invoked by alias); 3 May 2008 15:59:18 -0000 Received: (qmail 6533 invoked by uid 22791); 3 May 2008 15:59:16 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 03 May 2008 15:58:56 +0000 Received: (qmail 31435 invoked from network); 3 May 2008 15:58:54 -0000 Received: from unknown (HELO localhost) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 3 May 2008 15:58:54 -0000 From: Vladimir Prus To: Daniel Jacobowitz , Eli Zaretskii Subject: Re: [RFA] Remove command_line_handler_continuation. Date: Sat, 03 May 2008 16:42:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: gdb-patches@sources.redhat.com References: <200804242033.40568.vladimir@codesourcery.com> <20080502150314.GL29202@caradoc.them.org> In-Reply-To: <20080502150314.GL29202@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805031958.39818.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00131.txt.bz2 On Friday 02 May 2008 19:03:14 Daniel Jacobowitz wrote: > On Thu, Apr 24, 2008 at 07:33:40PM +0300, Vladimir Prus wrote: > > > > With my previous patch to move all bpstat_do_actions calls into > > event handler, all that command_line_handler_continuation does > > is to print timings, if those are enabled. However, those timings > > don't make much sense. Timings are good for debugging GDB performance, > > and in case of command_line_handler_continuation, the times will report > > the time when the application run. > > > > So, this patch removes that continuation. OK? > > OK once you and Eli agree about documenting the timings. Here's a revision with doc clarification. Eli, does it look sufficient? - Volodya