From: Daniel Jacobowitz <drow@false.org>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] PR gdb/1665 pending catch/throw catchpoints
Date: Thu, 01 May 2008 20:07:00 -0000 [thread overview]
Message-ID: <20080501200654.GN22218@caradoc.them.org> (raw)
In-Reply-To: <fv80t2$hv9$1@ger.gmane.org>
On Tue, Apr 29, 2008 at 04:36:47PM -0400, Aleksandar Ristovski wrote:
> PR gdb/1665
> * breakpoint.c (create_breakpoint): Add breakpoint_ops argument and
> assign its value to the breakpoint created.
> (create_breakpoints): Add breakpoint_ops argument and pass it
> to create_breakpoint call.
> (break_command_really): Add breakpoint_ops argument and pass/assign
> appropriately.
> (break_command_1): Pass NULL as ops argument.
> (set_breakpoint): Pass NULL as ops argument.
> (print_one_exception_catchpoint): Print <PENDING> if no loc available.
> (handle_gnu_v3_exceptions): Call generic breakpoint code to insert
> catch and throw catchpoints.
Nice patch! This is OK.
> - update_global_location_list ();
> return 1;
> +
> }
Please don't add this blank line though.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-05-01 20:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 22:30 Aleksandar Ristovski
2008-04-30 7:09 ` Aleksandar Ristovski
2008-05-01 20:13 ` Daniel Jacobowitz
2008-05-02 17:55 ` Aleksandar Ristovski
2008-05-02 18:07 ` Aleksandar Ristovski
2008-06-05 16:06 ` Daniel Jacobowitz
2008-06-05 16:40 ` Aleksandar Ristovski
2008-06-05 17:36 ` Daniel Jacobowitz
2008-06-05 18:40 ` Aleksandar Ristovski
2008-05-01 20:07 ` Daniel Jacobowitz [this message]
2008-05-01 20:38 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501200654.GN22218@caradoc.them.org \
--to=drow@false.org \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox