From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13211 invoked by alias); 1 May 2008 20:07:17 -0000 Received: (qmail 13104 invoked by uid 22791); 1 May 2008 20:07:16 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 May 2008 20:06:57 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7F971983D6; Thu, 1 May 2008 20:06:55 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 6AAEF98366; Thu, 1 May 2008 20:06:55 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Jrf3O-0007VJ-S0; Thu, 01 May 2008 16:06:54 -0400 Date: Thu, 01 May 2008 20:07:00 -0000 From: Daniel Jacobowitz To: Aleksandar Ristovski Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] PR gdb/1665 pending catch/throw catchpoints Message-ID: <20080501200654.GN22218@caradoc.them.org> Mail-Followup-To: Aleksandar Ristovski , gdb-patches@sources.redhat.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00035.txt.bz2 On Tue, Apr 29, 2008 at 04:36:47PM -0400, Aleksandar Ristovski wrote: > PR gdb/1665 > * breakpoint.c (create_breakpoint): Add breakpoint_ops argument and > assign its value to the breakpoint created. > (create_breakpoints): Add breakpoint_ops argument and pass it > to create_breakpoint call. > (break_command_really): Add breakpoint_ops argument and pass/assign > appropriately. > (break_command_1): Pass NULL as ops argument. > (set_breakpoint): Pass NULL as ops argument. > (print_one_exception_catchpoint): Print if no loc available. > (handle_gnu_v3_exceptions): Call generic breakpoint code to insert > catch and throw catchpoints. Nice patch! This is OK. > - update_global_location_list (); > return 1; > + > } Please don't add this blank line though. -- Daniel Jacobowitz CodeSourcery