Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Implement thread death notification.
Date: Thu, 01 May 2008 20:04:00 -0000	[thread overview]
Message-ID: <20080501200353.GM22218@caradoc.them.org> (raw)
In-Reply-To: <200804262121.51407.vladimir@codesourcery.com>

On Sat, Apr 26, 2008 at 08:21:50PM +0300, Vladimir Prus wrote:
> 
> We now have the 'thread-created' MI notification. This patch adds a
> 'thread-exited' notification to match. Are non-MI bits of this
> patch OK?

No, I don't think this is good enough.  It's "thread has exited but
only if the target is native GNU/Linux".  While for some targets we
will not detect thread exit until "info threads", which is
unfortunate, at least the code to call the observer should be in
generic code.  Can't we call it from delete_thread?

Also, please do not commit without documentation for the notification.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-05-01 20:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26 17:45 Vladimir Prus
2008-05-01 20:04 ` Daniel Jacobowitz [this message]
2008-05-01 20:13   ` Vladimir Prus
2008-05-01 20:21     ` Daniel Jacobowitz
2008-04-27 15:03 Nick Roberts
2008-04-29 20:07 ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080501200353.GM22218@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox