From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6746 invoked by alias); 1 May 2008 20:04:16 -0000 Received: (qmail 6732 invoked by uid 22791); 1 May 2008 20:04:15 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 May 2008 20:03:56 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id CEDA2983D6; Thu, 1 May 2008 20:03:54 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id A7F2698366; Thu, 1 May 2008 20:03:54 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Jrf0U-0007Uw-0c; Thu, 01 May 2008 16:03:54 -0400 Date: Thu, 01 May 2008 20:04:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Implement thread death notification. Message-ID: <20080501200353.GM22218@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200804262121.51407.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200804262121.51407.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00034.txt.bz2 On Sat, Apr 26, 2008 at 08:21:50PM +0300, Vladimir Prus wrote: > > We now have the 'thread-created' MI notification. This patch adds a > 'thread-exited' notification to match. Are non-MI bits of this > patch OK? No, I don't think this is good enough. It's "thread has exited but only if the target is native GNU/Linux". While for some targets we will not detect thread exit until "info threads", which is unfortunate, at least the code to call the observer should be in generic code. Can't we call it from delete_thread? Also, please do not commit without documentation for the notification. -- Daniel Jacobowitz CodeSourcery