Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: luisgpm@linux.vnet.ibm.com
Cc: gdb-patches@sourceware.org
Subject: Re: continuations and breakpoint commands
Date: Wed, 30 Apr 2008 14:21:00 -0000	[thread overview]
Message-ID: <200804301416.19459.pedro@codesourcery.com> (raw)
In-Reply-To: <1209559986.7131.9.camel@gargoyle>

A Wednesday 30 April 2008 13:53:05, Luis Machado wrote:
> Pedro,
>
> On Tue, 2008-04-29 at 22:21 +0100, Pedro Alves wrote:
> > This patch fixes continuation handling in async mode, by making
> > the handling sequence match the sync code path.
>
> Thanks for the patch. The commands.exp testcase is now clear for PPC.
> Didn't see any regressions.
>

Thanks for testing.

> Just a minor gotcha:
>
> -      /* If the continuation did not start the target again,
> -        prepare for interation with the user.  */
> +      /* If no breakpoint command resumed the inferior, prepare for
> +        >>interation<< with the user.  */
>
> Is "interation" supposed to be "interaction"?
>

Yep.  Thanks for spotting that.  We're going to display the prompt
so the user can enter commands, that's what it means.

-- 
Pedro Alves


  reply	other threads:[~2008-04-30 13:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30  5:59 Pedro Alves
2008-04-30 14:03 ` Luis Machado
2008-04-30 14:21   ` Pedro Alves [this message]
2008-04-30 17:00     ` Pierre Muller
2008-04-30 18:25       ` Pedro Alves
2008-05-02 15:38         ` Daniel Jacobowitz
2008-05-04 22:49           ` Pedro Alves
2008-05-02 15:44 ` Daniel Jacobowitz
2008-05-07  4:33   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804301416.19459.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luisgpm@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox