From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9591 invoked by alias); 30 Apr 2008 13:16:41 -0000 Received: (qmail 9581 invoked by uid 22791); 30 Apr 2008 13:16:40 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 Apr 2008 13:16:23 +0000 Received: (qmail 16901 invoked from network); 30 Apr 2008 13:16:21 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Apr 2008 13:16:21 -0000 From: Pedro Alves To: luisgpm@linux.vnet.ibm.com Subject: Re: continuations and breakpoint commands Date: Wed, 30 Apr 2008 14:21:00 -0000 User-Agent: KMail/1.9.9 Cc: gdb-patches@sourceware.org References: <200804292221.52239.pedro@codesourcery.com> <1209559986.7131.9.camel@gargoyle> In-Reply-To: <1209559986.7131.9.camel@gargoyle> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804301416.19459.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00698.txt.bz2 A Wednesday 30 April 2008 13:53:05, Luis Machado wrote: > Pedro, > > On Tue, 2008-04-29 at 22:21 +0100, Pedro Alves wrote: > > This patch fixes continuation handling in async mode, by making > > the handling sequence match the sync code path. > > Thanks for the patch. The commands.exp testcase is now clear for PPC. > Didn't see any regressions. > Thanks for testing. > Just a minor gotcha: > > - /* If the continuation did not start the target again, > - prepare for interation with the user. */ > + /* If no breakpoint command resumed the inferior, prepare for > + >>interation<< with the user. */ > > Is "interation" supposed to be "interaction"? > Yep. Thanks for spotting that. We're going to display the prompt so the user can enter commands, that's what it means. -- Pedro Alves