From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Handle DW_AT_const_value/DW_FORM_strp variables
Date: Fri, 25 Apr 2008 19:45:00 -0000 [thread overview]
Message-ID: <20080425182858.GB841@adacore.com> (raw)
In-Reply-To: <200804251915.27580.pedro@codesourcery.com>
Hi Pedro,
> gdb/
> 2008-04-25 Pedro Alves <pedro@codesourcery.com>
>
> * dwarf2read.c (dwarf2_const_value): Handle DW_FORM_strp.
>
> gdb/testsuite/
> 2008-04-25 Pedro Alves <pedro@codesourcery.com>
>
> * gdb.dwarf2/dw2-strp.S, gdb.dwarf2/dw2-strp.exp: New files.
Both patches look good to me. Please go ahead and commit.
> +# This test can only be run on targets which support DWARF-2 and use gas.
> +# For now pick a sampling of likely targets.
> +if {![istarget *-*-linux*]
> + && ![istarget *-*-gnu*]
> + && ![istarget *-*-elf*]
> + && ![istarget *-*-openbsd*]
> + && ![istarget arm-*-eabi*]
> + && ![istarget powerpc-*-eabi*]} {
> + return 0
> +}
I wonder if we should put that in a function somewhere. We have been
repeating this pretty large condition in several files, now. Just
thinking out loud...
--
Joel
next prev parent reply other threads:[~2008-04-25 18:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 19:19 Pedro Alves
2008-04-25 19:45 ` Joel Brobecker [this message]
2008-04-25 20:14 ` Pedro Alves
2008-04-30 13:58 ` Luis Machado
2008-04-30 14:12 ` Pedro Alves
2008-04-30 14:36 ` Daniel Jacobowitz
2008-04-30 14:42 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080425182858.GB841@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox