From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-55455-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25137 invoked by alias); 25 Apr 2008 18:29:20 -0000
Received: (qmail 25125 invoked by uid 22791); 25 Apr 2008 18:29:20 -0000
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 25 Apr 2008 18:29:03 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) 	by filtered-rock.gnat.com (Postfix) with ESMTP id 57CFE2A9E18; 	Fri, 25 Apr 2008 14:29:01 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1]) 	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) 	with LMTP id 9a5TEJlKbwut; Fri, 25 Apr 2008 14:29:01 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) 	by rock.gnat.com (Postfix) with ESMTP id 1EB452A9E17; 	Fri, 25 Apr 2008 14:29:01 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id 08420E7ACD; Fri, 25 Apr 2008 11:28:58 -0700 (PDT)
Date: Fri, 25 Apr 2008 19:45:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Handle DW_AT_const_value/DW_FORM_strp variables
Message-ID: <20080425182858.GB841@adacore.com>
References: <200804251915.27580.pedro@codesourcery.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200804251915.27580.pedro@codesourcery.com>
User-Agent: Mutt/1.4.2.2i
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-04/txt/msg00579.txt.bz2

Hi Pedro,

> gdb/
> 2008-04-25  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* dwarf2read.c (dwarf2_const_value): Handle DW_FORM_strp.
> 
> gdb/testsuite/
> 2008-04-25  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* gdb.dwarf2/dw2-strp.S, gdb.dwarf2/dw2-strp.exp: New files.

Both patches look good to me. Please go ahead and commit.

> +# This test can only be run on targets which support DWARF-2 and use gas.
> +# For now pick a sampling of likely targets.
> +if {![istarget *-*-linux*]
> +    && ![istarget *-*-gnu*]
> +    && ![istarget *-*-elf*]
> +    && ![istarget *-*-openbsd*]
> +    && ![istarget arm-*-eabi*]
> +    && ![istarget powerpc-*-eabi*]} {
> +    return 0
> +}

I wonder if we should put that in a function somewhere. We have been
repeating this pretty large condition in several files, now. Just
thinking out loud...

-- 
Joel