From: Vladimir Prus <vladimir@codesourcery.com>
To: Aleksandar Ristovski <ARistovski@qnx.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] fix for PR2424
Date: Wed, 23 Apr 2008 17:49:00 -0000 [thread overview]
Message-ID: <200804231753.15808.vladimir@codesourcery.com> (raw)
In-Reply-To: <480F3D0D.7090606@qnx.com>
On Wednesday 23 April 2008 17:43:41 Aleksandar Ristovski wrote:
> Vladimir Prus wrote:
> > Aleksandar Ristovski wrote:
> >
> >> NOTE3: In mi-support.exp (mi_expect_stop), I put argument "after_reason"
> to
> >> be
> >> after the reason
> >
> > Why? Neither your email nor changelog entry fail to explain the motivation
> > for the change.
> >
>
> The field is named "after_reason" and it hadn't been used. It looked like
> someone meant to use it for after reason field, but was placed after
> 'thread-id' field - I might have made wrong conclusion, this is why I
> emphasised the change in the note above.
>
> It is a local variable so it should not be a problem to switch it back, add
> new param for 'disp' field or whatever.
I see. I did not realize that this variable is actually used *after* your patch,
so wondered why changing a variable if it has no effect. So far, except for
a couple of conflicts, I did not run into any issues with this change.
Thanks for explaining,
Volodya
next prev parent reply other threads:[~2008-04-23 13:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 17:48 Aleksandar Ristovski
2008-04-23 17:49 ` Vladimir Prus [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-16 18:28 Aleksandar Ristovski
2008-04-15 15:31 Aleksandar Ristovski
2008-04-15 15:07 Aleksandar Ristovski
2008-04-15 15:25 ` Daniel Jacobowitz
2008-04-16 13:17 ` Vladimir Prus
2008-04-23 11:16 ` Vladimir Prus
2008-04-14 15:16 Aleksandar Ristovski
2008-04-14 18:06 ` Daniel Jacobowitz
2008-04-01 19:41 Aleksandar Ristovski
2008-03-05 17:36 Aleksandar Ristovski
2008-03-08 11:31 ` Nick Roberts
2008-03-08 18:36 ` Vladimir Prus
2008-03-09 0:12 ` Aleksandar Ristovski
2008-03-09 3:32 ` Nick Roberts
2008-03-09 4:55 ` Aleksandar Ristovski
2008-03-10 8:11 ` Vladimir Prus
2008-03-10 14:29 ` Aleksandar Ristovski
2008-03-10 14:45 ` Vladimir Prus
2008-03-10 17:18 ` Aleksandar Ristovski
2008-03-10 17:36 ` Vladimir Prus
2008-03-10 18:50 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804231753.15808.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=ARistovski@qnx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox