From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1993 invoked by alias); 23 Apr 2008 13:53:45 -0000 Received: (qmail 1973 invoked by uid 22791); 23 Apr 2008 13:53:44 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 Apr 2008 13:53:27 +0000 Received: (qmail 28034 invoked from network); 23 Apr 2008 13:53:25 -0000 Received: from unknown (HELO 172.16.unknown.plus.ru) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Apr 2008 13:53:24 -0000 From: Vladimir Prus To: Aleksandar Ristovski Subject: Re: [patch] fix for PR2424 Date: Wed, 23 Apr 2008 17:49:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: gdb-patches@sourceware.org References: <480F3D0D.7090606@qnx.com> In-Reply-To: <480F3D0D.7090606@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804231753.15808.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00522.txt.bz2 On Wednesday 23 April 2008 17:43:41 Aleksandar Ristovski wrote: > Vladimir Prus wrote: > > Aleksandar Ristovski wrote: > > > >> NOTE3: In mi-support.exp (mi_expect_stop), I put argument "after_reason" > to > >> be > >> after the reason > > > > Why? Neither your email nor changelog entry fail to explain the motivation > > for the change. > > > > The field is named "after_reason" and it hadn't been used. It looked like > someone meant to use it for after reason field, but was placed after > 'thread-id' field - I might have made wrong conclusion, this is why I > emphasised the change in the note above. > > It is a local variable so it should not be a problem to switch it back, add > new param for 'disp' field or whatever. I see. I did not realize that this variable is actually used *after* your patch, so wondered why changing a variable if it has no effect. So far, except for a couple of conflicts, I did not run into any issues with this change. Thanks for explaining, Volodya