Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: MI testsuite fix
Date: Mon, 21 Apr 2008 15:05:00 -0000	[thread overview]
Message-ID: <200804211531.44652.pedro@codesourcery.com> (raw)
In-Reply-To: <20080421123258.GA29008@caradoc.them.org>

A Monday 21 April 2008 13:32:58, Daniel Jacobowitz wrote:
> On Mon, Apr 21, 2008 at 12:35:58PM +0100, Pedro Alves wrote:

> > Now you've lost me.  This is mapping absolute section addresses
> > to section offsets.  It doesn't seem symfile_map_offsets_to_segments
> > or objfile_relocate would give any help here?
>
> Well, anything that just carries offsets forwards from the previous
> section is suspect.  If the user gives us the addresses of .text and
> .data, it'd be nice to move the containing segments appropriately.
>

I see.  We could also give the user an option to pass segment
addresses instead of section addresses, and then it indeed starts
looking like qOffsets.

> > 2008-04-21  Pedro Alves  <pedro@codesourcery.com>
> >
> > 	* symfile.c (syms_from_objfile): Don't warn if lowest loadable
> > 	section is not a code section.
>
> OK.

Checked in.  Thanks.

-- 
Pedro Alves


      reply	other threads:[~2008-04-21 14:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10 20:37 Pedro Alves
2008-04-10 21:42 ` Luis Machado
2008-04-10 22:10   ` Pedro Alves
2008-04-10 23:13 ` Pedro Alves
2008-04-14 18:27 ` Daniel Jacobowitz
2008-04-21 12:58   ` Pedro Alves
2008-04-21 14:04     ` Daniel Jacobowitz
2008-04-21 15:05       ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804211531.44652.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox