Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <ghost@cs.msu.su>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Avoid breakpoint query in MI
Date: Sat, 19 Apr 2008 00:10:00 -0000	[thread overview]
Message-ID: <200804182247.50169.ghost@cs.msu.su> (raw)
In-Reply-To: <18439.53229.583886.798613@kahikatea.snap.net.nz>

On Friday 18 April 2008 02:32:13 Nick Roberts wrote:
>  > Please name this top_level_interpreter. Also, the return type
>  > should be "struct interp*". In fact, I have a not-yet-submitted
>  > patches which does just that :-)
> 
> Actually I can't cal it top_level_interpreter because you've already used
> that name:
> 
> static struct interp *top_level_interpreter = NULL;

This is 'static', nobody cares how it's called. My patch has this bit:


@@ -78,13 +78,13 @@ static char **interpreter_completer (char *text, char *word);
 void _initialize_interpreter (void);
 
 /* Variables local to this file: */
 
 static struct interp *interp_list = NULL;
 static struct interp *current_interpreter = NULL;
-static struct interp *top_level_interpreter = NULL;
+static struct interp *top_level_interpreter_ptr = NULL;
 
 static int interpreter_initialized = 0;
 
 /* interp_new - This allocates space for a new interpreter,
    fills the fields from the inputs, and returns a pointer to the
    interpreter. */

- Volodya


      reply	other threads:[~2008-04-18 18:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 15:12 Nick Roberts
2008-04-17 16:42 ` Vladimir Prus
2008-04-17 21:25   ` Nick Roberts
     [not found]     ` <200804180153.32013.ghost@cs.msu.su>
2008-04-19 14:12       ` Nick Roberts
2008-04-19 17:07         ` Daniel Jacobowitz
2008-04-20  7:20           ` Nick Roberts
2008-04-21  7:10           ` Eli Zaretskii
2008-04-17 23:02   ` Nick Roberts
2008-04-19  0:10     ` Vladimir Prus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804182247.50169.ghost@cs.msu.su \
    --to=ghost@cs.msu.su \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox