From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31550 invoked by alias); 18 Apr 2008 18:48:27 -0000 Received: (qmail 31541 invoked by uid 22791); 18 Apr 2008 18:48:26 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 18 Apr 2008 18:48:04 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.63) (envelope-from ) id 1Jmvcs-0001iW-IL for gdb-patches@sources.redhat.com; Fri, 18 Apr 2008 22:48:01 +0400 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Jmvcl-0001iH-HI; Fri, 18 Apr 2008 22:47:51 +0400 From: Vladimir Prus To: Nick Roberts Subject: Re: [PATCH] Avoid breakpoint query in MI Date: Sat, 19 Apr 2008 00:10:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: gdb-patches@sources.redhat.com References: <18439.18322.632208.43670@kahikatea.snap.net.nz> <18439.53229.583886.798613@kahikatea.snap.net.nz> In-Reply-To: <18439.53229.583886.798613@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804182247.50169.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00386.txt.bz2 On Friday 18 April 2008 02:32:13 Nick Roberts wrote: > > Please name this top_level_interpreter. Also, the return type > > should be "struct interp*". In fact, I have a not-yet-submitted > > patches which does just that :-) > > Actually I can't cal it top_level_interpreter because you've already used > that name: > > static struct interp *top_level_interpreter = NULL; This is 'static', nobody cares how it's called. My patch has this bit: @@ -78,13 +78,13 @@ static char **interpreter_completer (char *text, char *word); void _initialize_interpreter (void); /* Variables local to this file: */ static struct interp *interp_list = NULL; static struct interp *current_interpreter = NULL; -static struct interp *top_level_interpreter = NULL; +static struct interp *top_level_interpreter_ptr = NULL; static int interpreter_initialized = 0; /* interp_new - This allocates space for a new interpreter, fills the fields from the inputs, and returns a pointer to the interpreter. */ - Volodya